fix(rtn-web-browser): Don't use custom tabs on default and fallback to normal tabs #14631
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadivus
requested review from
avi-karthik,
pranavosu and
sarayev
as code owners
ahmedhamouda78
approved these changes
Nov 17, 2025
osama-rizk
reviewed
Nov 18, 2025
osama-rizk
approved these changes
Nov 18, 2025
sarayev
approved these changes
Nov 18, 2025
cadivus
force-pushed
the
rtn-web-browser/custom-tab-fallback
branch
from
0fa4919 to
4b958ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #14523 to change the fallback order. The ChromeOS way works everywhere, the Android not. And the Android tab opening needs to be awaited so that we can catch it. It should also fix #14459
Description of changes
Issue #, if available
#14523
#14459
Description of how you validated changes
I used a Chromebook and the Android emulator. Both do the expected.
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.